Skip to content

feat(hooks): recognize Chinese keywords in the delegation nudge #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leon7786 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(hooks): recognize Chinese keywords in the delegation nudge #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions hooks/nudge-delegation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# never fires the wrapper itself: full automation is a measured net loss below
# the break-even, so the break-even call must remain a per-task judgment.
#
# Heuristic is deliberately conservative (volume/fan-out phrases, EN + JA), and
# Heuristic is deliberately conservative (volume/fan-out phrases, EN + JA + ZH), and
# the nudge text is a FIXED string — the user's prompt is never echoed back into
# the context (no escaping/injection surface).
#
Expand Down Expand Up @@ -39,7 +39,11 @@ case "$PROMPT" in
*"all files"*|*"every file"*|*"across the codebase"*|*"entire codebase"*|*"whole repo"*| \
*migrate*|*migration*|*"generate tests"*|*"test coverage"*|*"exhaustive test"*| \
*scaffold*|*boilerplate*|*"deep research"*|*"web search"*| \
*一括*|*全ファイル*|*すべてのファイル*|*網羅*|*移行*|*大量*|*横断*|*リポジトリ全体*)
*一括*|*全ファイル*|*すべてのファイル*|*網羅*|*移行*|*大量*|*横断*|*リポジトリ全体*| \
*批量*|*全量*|*所有文件*|*全部文件*|*整个项目*|*整个仓库*|*整个代码库*| \
*迁移*|*生成测试*|*测试覆盖*|*全套测试*|*脚手架*|*深度研究*|*调研*|*联网搜索*|*网页搜索*|*遍历*|*逐一*| \
*子代理*|*子agent*|*"子 agent"*|*交叉验证*|*交叉核对*|*双模型*|*第二意见*|*复核*| \
*审查*|*代码审查*|*审阅*|*校对*|*并行*|*批量生成*|*通读*)

@github-actions github-actions Bot Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of these are broader than their EN/JA counterparts and could add false positives to an otherwise "deliberately conservative" list (per the header comment): 校对 (proofread), 复核 (double-check), 通读 (read through), and 审阅/审查 (review) can show up in small, non-bulk asks like "帮我校对这段话" or "复核一下这个函数". Worth double-checking whether these are meant to stay this broad — since the nudge is advisory-only and non-blocking this is low severity, but it's a bit inconsistent with the EN list, which has no generic "review" trigger at all.

HIT=1 ;;
esac
shopt -u nocasematch
Expand Down
Loading