fix: call herdr pane wait-output instead of herdr wait output - #14
Open
silacode wants to merge 1 commit into
Open
fix: call herdr pane wait-output instead of herdr wait output#14silacode wants to merge 1 commit into
herdr pane wait-output instead of herdr wait output#14silacode wants to merge 1 commit into
Conversation
`wait_output_args` built `herdr wait output <pane_id> ...`, but the herdr CLI exposes this as `herdr pane wait-output <pane_id> ...`. herdr exits 2 with "unknown command: wait", so `apply` aborts at the first pane declaring `wait_for` and leaves the workspace half-built. The unit test and the fake-herdr integration test both asserted the same incorrect argv, so the bug was invisible in CI. All three are corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
wait_output_argsemittedherdr wait output <pane_id> ..., but the herdrCLI exposes this as
herdr pane wait-output <pane_id> .... herdr exits 2 withunknown command: wait, soapplyaborts at the first pane declaringwait_forand leaves the workspace half-built.The unit test in
src/backend/cli.rsand the fake-herdr integration test intests/cli_backend_integration.rsboth asserted the same incorrect argv, whichis why CI never caught this — so this changes the builder and both tests.
Verified against herdr 0.8.0: a two-pane layout with
wait_foron the firstpane now applies completely.
cargo fmt --check,cargo clippy -- -D warnings, andcargo testall pass.