Bugfix/xpcall number args #467
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waschik
commented
Dec 14, 2023
| fn := L.CheckFunction(1) | ||
| errfunc := L.CheckFunction(2) | ||
|
|
||
| L.Remove(2) |
There was a problem hiding this comment.
@yuin I am nut sure if removing element is fine. But as fare as I understand at the end of baseXPCall all arguments are anyway removed from stack.
So removing is a bit simpler then manually duplicate all arguments. For performance there is no use because remove will be sure no improvement because remove will also copy values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464.
Pass function arguments. Previously the function was called always with zero arguments.