Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] PG15 Online Upgrade: Re-enable check_for_isn_and_int8_passing_mismatch #25428

Closed
1 task done
timothy-e opened this issue Dec 24, 2024 · 0 comments
Closed
1 task done
Assignees
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@timothy-e
Copy link
Contributor

timothy-e commented Dec 24, 2024

Jira Link: DB-14659

Description

/* Enable this check when contrib directory is enabled in build_postgres.py */, and the contrib directory is supported as of D36639 / caa16a6

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@timothy-e timothy-e added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Dec 24, 2024
@timothy-e timothy-e self-assigned this Dec 24, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Dec 24, 2024
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Jan 2, 2025
timothy-e added a commit that referenced this issue Jan 13, 2025
Summary:
This YB_TODO had a comment above it: `/* Enable this check when contrib directory is enabled in build_postgres.py */`.

The contrib directory was enabled by D36639 / caa16a6, so it is now
safe to re-enable this check.
Jira: DB-14659

Test Plan: Jenkins

Reviewers: hsunder, fizaa

Reviewed By: hsunder

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D40885
vpatibandla-yb pushed a commit that referenced this issue Jan 16, 2025
Summary:
This YB_TODO had a comment above it: `/* Enable this check when contrib directory is enabled in build_postgres.py */`.

The contrib directory was enabled by D36639 / caa16a6, so it is now
safe to re-enable this check.
Jira: DB-14659

Test Plan: Jenkins

Reviewers: hsunder, fizaa

Reviewed By: hsunder

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D40885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

2 participants