Skip to content

Commit c33c076

Browse files
timothy-evpatibandla-yb
authored andcommitted
[#25428] YSQL: enable check_for_isn_and_int8_passing_mismatch
Summary: This YB_TODO had a comment above it: `/* Enable this check when contrib directory is enabled in build_postgres.py */`. The contrib directory was enabled by D36639 / caa16a6, so it is now safe to re-enable this check. Jira: DB-14659 Test Plan: Jenkins Reviewers: hsunder, fizaa Reviewed By: hsunder Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D40885
1 parent 4f38f73 commit c33c076

File tree

1 file changed

+1
-3
lines changed
  • src/postgres/src/bin/pg_upgrade

1 file changed

+1
-3
lines changed

src/postgres/src/bin/pg_upgrade/check.c

+1-3
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,8 @@ check_and_dump_old_cluster(bool live_check)
107107
check_for_prepared_transactions(&old_cluster);
108108
check_for_composite_data_type_usage(&old_cluster);
109109
check_for_reg_data_type_usage(&old_cluster);
110-
#ifdef YB_TODO
111-
/* Enable this check when contrib directory is enabled in build_postgres.py */
110+
112111
check_for_isn_and_int8_passing_mismatch(&old_cluster);
113-
#endif
114112

115113
/*
116114
* PG 14 changed the function signature of encoding conversion functions.

0 commit comments

Comments
 (0)