Skip to content

Commit

Permalink
[#25125] YSQL: Fix bitmap scan test timeouts in TSAN
Browse files Browse the repository at this point in the history
Summary:
The bitmap scan tests are flakey in TSAN because of timeouts. On my devserver, running just the yb_bitmap_scans.sql regress test took 20 minutes and 8 seconds. I found most of the time was spent creating tables and indexes, so I rewrote the tests to reuse tables and indexes, even if there were just a few rows in the table.
For both yb_bitmap_scans.sql and yb_bitmap_scans_colo.sql:
* Lots of simple cases now use `simple` instead of their own table.
* Recheck tests all use the same recheck table, with 3 columns in it for each of the three cases.
* Removed the table `pk_int`, because a table with an integer primary key already existed.

This reduced the test time on TSAN on my devserver for yb_bitmap_scans.sql from 20:08 to 8:22, a
nearly 60% reduction. This should resolve the timeouts in Jenkins.
Jira: DB-14272

Test Plan:
Jenkins: build type: tsan, test regex: .*TestPgRegressYbBitmapScans.*

```
./yb_build.sh tsan --java-test 'org.yb.pgsql.TestPgRegressYbBitmapScans'
```

Reviewers: amartsinchyk, tnayak

Reviewed By: amartsinchyk

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D40358
  • Loading branch information
timothy-e committed Dec 11, 2024
1 parent f0627be commit 7b10bbf
Show file tree
Hide file tree
Showing 4 changed files with 1,668 additions and 2,027 deletions.
Loading

0 comments on commit 7b10bbf

Please sign in to comment.