Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Unit test failing due to recent PR merging using code changed in build tags PR #2124

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

sanyamsinghal
Copy link
Collaborator

Describe the changes in this pull request

Fixes the regression introduced in bbfc84c
fatalIfError was renamed to testutils.FatalIfError()in this commit, but recent commit was still using old name and git merge was unable to detect this conflict.

Describe if there are any user-facing changes

NA

How was this pull request tested?

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB Yes/No
Name registry json Yes/No
Data File Descriptor Json Yes/No
Export Snapshot Status Json Yes/No
Import Data State Yes/No
Export Status Json Yes/No
Data .sql files of tables Yes/No
Export and import data queue Yes/No
Schema Dump Yes/No
AssessmentDB Yes/No
Sizing DB Yes/No
Migration Assessment Report Json Yes/No
Callhome Json Yes/No
YugabyteD Tables Yes/No
TargetDB Metadata Tables Yes/No

@sanyamsinghal sanyamsinghal merged commit d148a04 into main Dec 27, 2024
43 of 45 checks passed
@sanyamsinghal sanyamsinghal deleted the sanyam/regression-tags branch December 27, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants