Do not add the feature in UnsupportedFeatures field if there are no objects for it in the JSON report #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…there are no object for it in the JSON report
| @@ -947,7 +947,7 @@ func areMinVersionsFixedInEqual(m1 map[string]*ybversion.YBVersion, m2 map[strin | |||
| return true | |||
| } | |||
|
|
|||
| func getUnsupportedFeaturesFromSchemaAnalysisReport(featureName string, issueReason string, schemaAnalysisReport utils.SchemaReport, displayDDLInHTML bool, description string) UnsupportedFeature { | |||
| func getUnsupportedFeaturesFromSchemaAnalysisReport(featureName string, issueReason string, schemaAnalysisReport utils.SchemaReport, displayDDLInHTML bool, description string) *UnsupportedFeature { | |||
There was a problem hiding this comment.
Instead of changing it to pointer, how about we keep the return type same.
And define EMPTY_UNSUPPORTED_FEATURE and return that, and later filter that out of the final array.
var EMPTY_UNSUPPORTED_FEATURE = UnsupportedFeature{}
There was a problem hiding this comment.
Changed the way to not make pointer changes, but just filter at the end if there are objects
sanyamsinghal
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Just thinking out loud after looking at the expected test results.
In case of UnsupportedFeatures it is null if there is nothing,
Whereas in case of migration caveats its a empty list - []
can we have the same behaviour in both cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Modified the code to not put the Feature in the UnsupportedFeatures field of the struct in case there are no objects for making JSON report cleaner. This will also help developers not to update the expected files every time we add new feature.
Describe if there are any user-facing changes
Json report will not have feature if there are no objects
How was this pull request tested?
Existing tests
https://jenkins.dev.yugabyte.com/job/users/job/yb-voyager-testing/job/yb-voyager-testing-pipeline/4300/ - 1 intermittent failure
https://jenkins.dev.yugabyte.com/job/users/job/yb-voyager-testing/job/yb-voyager-testing-pipeline/4301
Does your PR have changes that can cause upgrade issues?