Integrated CheckRequiredToolsAreInstalled() function into checkDependenciesForExport() function #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enciesForExport() function
ShivanshGahlot
requested review from
sanyamsinghal,
makalaaneesh and
priyanshi-yb
|
|
||
| missingTools = utils.CheckTools("strings") | ||
|
|
||
| case MYSQL: |
There was a problem hiding this comment.
minor improvement: for mysql, oracle, you can skip the ora2pg check if it's live migration.
(add a todo for now, because as I see this function is called in lots of places - exportschema, exportdata, assess-migration)
There was a problem hiding this comment.
Added a TODO statement and created a ticket:
#2102
sanyamsinghal
approved these changes
Dec 18, 2024
yb-voyager/src/utils/utils.go
Outdated
| for _, tool := range tools { | ||
| execPath, err := exec.LookPath(tool) | ||
| if err != nil { | ||
| missingTools = append(missingTools, fmt.Sprintf("%s", tool)) |
There was a problem hiding this comment.
missingTools = append(missingTools, tool) ??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
We had a function CheckRequiredToolsAreInstalled() in the source db interface which we were using to check whether tools like strings, ora2pg, sqlplus were present or not. In this PR I have merged that function into checkDependenciesForExport() which is run along with the guardrails.
Describe if there are any user-facing changes
There is an addition in the command line output for missing dependencies. The overall structure is same. Just that the above mentioned tools will also be shown:
How was this pull request tested?
This PR was tested manually. I removed the binaries from their locations and tried to get the output for which binaries are missing. No need to add integration tests.
Does your PR have changes that can cause upgrade issues?