Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added common deployment scripts for CFN, GDM and ARM. #25

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

baba230896
Copy link
Contributor

Original issue: Migrate to use common utilities repo instead of self contained scripts

  • Added common scripts for CFN, ARM, and GDM in common_scripts/ folder.
  1. create_universe.sh
  2. install_software.sh
  • Removed dedicated scripts for ARM from azure_scripts folder.
  • Well-tested with CFN, ARM, and GDM. However, repo' needs some modification to work with common scripts. Below-mentioned links are of related PRs:

Copy link
Collaborator

@iSignal iSignal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have not already, I would recommend running shellcheck on the bash script to identify any bugs.

@iSignal iSignal merged commit 2206c70 into yugabyte:master Jun 10, 2020
@iSignal
Copy link
Collaborator

iSignal commented Jun 10, 2020

Merging it for now so that the cloudformation repo works properly. One action item in a new PR would be to add some comments explaining that the create_universe script in common_scripts runs on each node invidually and does the master addresses computation locally (so the order of IPs passed in as params has to be the same across all the nodes).

@baba230896
Copy link
Contributor Author

Sure @iSignal
We'll keep this in mind and update it with the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants