Add useful derive traits #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added normal useful traits on
Chartand all affected parts that needed it. Deriving these useful traits makes it a lot easier to work with charming in a more dynamic context like wasm. Deriving these traits has no downside but we should try our best to not remove them in the future, but with most of the functionality already implemented I think this won't be a problem.We are unable to derive
PartialOrdonChartbecause we can not derivePartialOrdonGeoMapOpt.GeoMapOptcontains the typeserde_json::Valuewhich does not implementPartialOrd. I don't know how we would go about circumventing that but I also don't think users of the library expect or needPartialOrdon the complete Chart. If a user needsPartialOrdonChartwe can look at that again.i will rebase this PR after we merge #85 and #77.
This PR will close these issues: fix #27, fix #35, fix #41
Implements some parts of #58