Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Candlestick OHLC example output #119

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

humphreylee
Copy link
Contributor

Add missing Candlestick OHLC example output

Add missing Candlestick OHLC example output
@LukaOber
Copy link
Collaborator

LukaOber commented Nov 8, 2024

I am hesitant to merge an example file which is 25k lines long. Wouldn't it be better to instead document how you can generate it?

@LukaOber
Copy link
Collaborator

LukaOber commented Nov 8, 2024

After a quick glance at the img folder I saw that the examples are svg files and not HTML. An SVG file would probably be wayy smaller. Especially if we reduce the amount of data.

@humphreylee
Copy link
Contributor Author

After a quick glance at the img folder I saw that the examples are svg files and not HTML. An SVG file would probably be wayy smaller. Especially if we reduce the amount of data.

Yes, this html was generated from this example. I can only do html output. Alternatively, I can do screenshots into png format. Unfortunately, I cannot get charming to output svg format on my locked down Windows machine.

@humphreylee
Copy link
Contributor Author

humphreylee commented Nov 8, 2024

What I appreciate about this example is how it demonstrates a workaround of creating error bars, a feature not yet available in the upstream ECharts. There are some examples of workaround in ECharts.

@humphreylee
Copy link
Contributor Author

Please hold on for now; I think the README should also be updated to link this image to its source.

@humphreylee
Copy link
Contributor Author

If you are fine with placing this example under "Custom Charts", it should be ready to merge.

@LukaOber
Copy link
Collaborator

LukaOber commented Nov 9, 2024

Are you able to remove the zoom element at the bottom and the toolbox at the top right? They are not relevant in an SVG.

@humphreylee
Copy link
Contributor Author

Are you able to remove the zoom element at the bottom and the toolbox at the top right? They are not relevant in an SVG.

Done.

@LukaOber
Copy link
Collaborator

Thank you very much for keeping up with my requests. LGTM

@LukaOber LukaOber merged commit c3f00c4 into yuankunzhang:main Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants