-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Candlestick OHLC example output #119
Add missing Candlestick OHLC example output #119
Conversation
Add missing Candlestick OHLC example output
I am hesitant to merge an example file which is 25k lines long. Wouldn't it be better to instead document how you can generate it? |
After a quick glance at the img folder I saw that the examples are svg files and not HTML. An SVG file would probably be wayy smaller. Especially if we reduce the amount of data. |
Yes, this html was generated from this example. I can only do html output. Alternatively, I can do screenshots into png format. Unfortunately, I cannot get charming to output svg format on my locked down Windows machine. |
What I appreciate about this example is how it demonstrates a workaround of creating error bars, a feature not yet available in the upstream ECharts. There are some examples of workaround in ECharts. |
Please hold on for now; I think the README should also be updated to link this image to its source. |
If you are fine with placing this example under "Custom Charts", it should be ready to merge. |
Are you able to remove the zoom element at the bottom and the toolbox at the top right? They are not relevant in an SVG. |
Done. |
Thank you very much for keeping up with my requests. LGTM |
Add missing Candlestick OHLC example output