Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing field to boxplot #106

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Add missing field to boxplot #106

merged 2 commits into from
Oct 28, 2024

Conversation

yg0x01
Copy link
Contributor

@yg0x01 yg0x01 commented Oct 22, 2024

I have added some content to the BoxPlot based on the ECharts documentation. Currently, the BoxPlot can set data using the Dataset method, but this requires using ECharts' standard algorithm for box plots and inputting the raw data. If our programs have already calculated the box plot results, such as lower_whisker, q1, q2, q3, upper_whisker, and outliers, there is currently no way to set the data directly.

@LukaOber
Copy link
Collaborator

Would you be so kind and switch the setter for ItemStyle to Into<Itemstyle>?

Can you provide an example, just so we can check that the implementation of data is working?

I believe the lint warnings are from new clippy features and have nothing to do with your PR. I will fix or ignore them in the coming days.

@humphreylee
Copy link
Contributor

Probably a long shot comment here. I am facing similar issue for scatter plot - say I have x, y, color_style, size_style, group_id, etc. Thus, I made a macro (dz!) to pass all these data into Echarts in this PR. It acts like df!, but handle many more data vectors.

@yg0x01
Copy link
Contributor Author

yg0x01 commented Oct 22, 2024

Would you be so kind and switch the setter for ItemStyle to Into<Itemstyle>?

Can you provide an example, just so we can check that the implementation of data is working?

I believe the lint warnings are from new clippy features and have nothing to do with your PR. I will fix or ignore them in the coming days.

Sure. Sorry for not checking this carefully. I will fix it (Into) and add some examples as soon as possible.

@yg0x01
Copy link
Contributor Author

yg0x01 commented Oct 22, 2024

Probably a long shot comment here. I am facing similar issue for scatter plot - say I have x, y, color_style, size_style, group_id, etc. Thus, I made a macro (dz!) to pass all these data into Echarts in this PR. It acts like df!, but handle many more data vectors.
.

It looks great! There are indeed too many ECharts configurations that can be added to this repo. It would be very helpful to have a macro that allows for flexible addition of configurations.

@LukaOber
Copy link
Collaborator

It looks great! There are indeed too many ECharts configurations that can be added to this repo. It would be very helpful to have a macro that allows for flexible addition of configurations.

I have written a proc macro which can expand to the setter pattern we are using. If you want, you can check it out or even review it #105

@LukaOber LukaOber merged commit 8d669d5 into yuankunzhang:main Oct 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants