Set @cluster_name in init job #645
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for setting the @cluster_name attribute in the init job during YTsaurus cluster initialization. The change refactors how cluster connection configuration is obtained and adds a new command to explicitly set the cluster name.
- Refactored to use
GetClusterConnection()directly instead ofGetClusterConnectionConfig()to access both the marshaled config and the cluster name field - Added a new init command that sets
//sys/@cluster_nameto the value fromclusterConn.ClusterName
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "/usr/bin/yt create map_node //home --ignore-existing", | ||
| RunIfExists("//sys/@provision_lock", fmt.Sprintf("/usr/bin/yt set //sys/@cluster_connection '%s'", string(clusterConnection))), | ||
| RunIfExists("//sys/@provision_lock", fmt.Sprintf("/usr/bin/yt set //sys/@cluster_connection '%s'", string(connConfig))), | ||
| RunIfExists("//sys/@provision_lock", fmt.Sprintf("/usr/bin/yt set //sys/@cluster_name '%s'", clusterConn.ClusterName)), |
There was a problem hiding this comment.
The cluster name is directly interpolated into the shell command without proper escaping. If the cluster name contains special characters like single quotes, this could break the command or potentially lead to command injection. Consider using proper shell escaping or validating that the cluster name doesn't contain problematic characters.
2 participants
closes #478