Added ca,ds and msc to the bulkUpdate mode #640
+216
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qurname2
force-pushed
the
qurname2/qurname2/rolling-update-bulk-mode
branch
from
12b592d to
f04b04f
Compare
qurname2
changed the title
qurname2
force-pushed
the
qurname2/qurname2/rolling-update-bulk-mode
branch
from
9b07304 to
6b69dcb
Compare
… so progress reporters can safely invoke them and avoid panics" This reverts commit c9ae727.
qurname2
force-pushed
the
qurname2/qurname2/rolling-update-bulk-mode
branch
from
6b69dcb to
8ef9ef7
Compare
koct9i
reviewed
Jan 7, 2026
| filter: "update && plan" | ||
| filter: "update && plan && !strategy" | ||
| - name: "update strategy" | ||
| filter: "update && plan && strategy" |
Collaborator
There was a problem hiding this comment.
Oh. This escalates quickly.
Probably we could reuse one cluster and run several "updates" on it in random order.
I don't want "mock" clusters or invent fictional unit-test but bootstrapping took most of the time. Probably we could snapshot state and recreate it much faster.
koct9i
reviewed
Jan 7, 2026
| }, | ||
| } | ||
| case consts.DiscoveryType: | ||
| ytsaurus.Spec.Discovery.Image = ptr.To(testutil.YtsaurusImagePrevious) |
Collaborator
There was a problem hiding this comment.
Let's use some another reason for instance restart rather than image change.
We could treak "zero-diff" in config overrides or in instance environment.
This way we could reuse same cluster between tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ca, ds and msc into the bulkMode. Should be rebased from main after master's PR is merged.