Update YTsaurus Images #635
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koct9i
force-pushed
the
khlebnikov/test-e2e-drop-version-23-2
branch
from
fd65daf to
a1f1c0d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes support for YTsaurus 23.2 from the test suite and updates sample configurations to use version 25.2.1 instead of 25.1.0.
- Removes 23.2 image definitions and related test configurations
- Updates sample configurations from 25.1.0 to 25.2.1
- Cleans up version-specific workarounds for 23.2 compatibility
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/ytsaurus_controller_test.go | Removes 23.2-specific master cache workaround and 23.2→24.1 upgrade test entry |
| test-env.inc | Removes 23.2 image exports and updates sample image to 25.2.1-relwithdebinfo |
| pkg/testutil/spec_builders.go | Removes YtsaurusImage23_2 constant, updates 25.2 version to 25.2.1, and removes 23.2-specific queue agent image override |
| config/samples/cluster_v1_tls.yaml | Updates coreImage from 25.1.0 to 25.2.1-relwithdebinfo |
| config/samples/cluster_v1_remoteexecnodes.yaml | Updates coreImage from dev-23.2 to 25.2.1-relwithdebinfo |
| config/samples/cluster_v1_cri.yaml | Updates coreImage from 25.1.0 to 25.2.1-relwithdebinfo |
The changes are clean and consistent. All references to version 23.2 have been properly removed from the test infrastructure, and all sample configurations have been updated to use the same version (25.2.1-relwithdebinfo). The removal of version-specific workarounds (master cache disabling and queue agent image override) makes the codebase simpler and more maintainable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koct9i
force-pushed
the
khlebnikov/test-e2e-drop-version-23-2
branch
from
a1f1c0d to
b17168c
Compare
koct9i
force-pushed
the
khlebnikov/test-e2e-drop-version-23-2
branch
from
b17168c to
30e55d2
Compare
koct9i
changed the title
- use 25.2.1 in samples - drop 23.2 image from tests - set current to 25.2 - set future to 25.3 Signed-off-by: Konstantin Khlebnikov <[email protected]>
koct9i
force-pushed
the
khlebnikov/test-e2e-drop-version-23-2
branch
from
30e55d2 to
8ebaa4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.