Validate update plan consistency

[koct9i]

• component types and class should be valid
• plan with class Nothing or Everything should not contain anything else

Signed-off-by: Konstantin Khlebnikov [email protected]

[Copilot]

Pull request overview

This PR adds validation to the update plan configuration in Ytsaurus resources to ensure update plan consistency. The validation enforces two main rules: (1) component types specified in update plans must be valid local component types, and (2) update plans with Nothing or Everything class selectors should not contain other selectors.

Key changes:

• Added component type validation against the LocalComponentTypes constant
• Extended the Nothing/Everything exclusivity validation to cover both Nothing and Everything classes
• Refactored field path construction to reduce code duplication

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The validation logic for Nothing/Everything class exclusivity is incorrect. The current condition (hasNothing || hasEverything) && i > 0 has two problems:

1. It only triggers when processing items after the first one, so if Nothing/Everything is at index 0 followed by other items, the error is reported at the wrong location (on the second item rather than explaining that Nothing/Everything must be alone).

2. If Nothing/Everything appears at index > 0, the error message incorrectly suggests it "should not contain anything more" when the real issue is that Nothing/Everything must be at index 0 and must be the only element.

The correct validation should check: if the current selector has Nothing or Everything class, verify that it's at index 0 AND the plan length is 1. Consider replacing with:

if updateSelector.Class == consts.ComponentClassNothing || updateSelector.Class == consts.ComponentClassEverything {
    if i != 0 || len(newYtsaurus.Spec.UpdatePlan) != 1 {
        allErrors = append(allErrors, field.Invalid(selectorPath, updateSelector, "Update plan with class Nothing or Everything must be the only element in the plan"))
    }
}

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[qurname2]

rebased from main, LGTM.