Update for latest triton-xdna#190
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates GGML’s HSA Triton (Triton-XDNA) integration to align with newer Triton-XDNA expectations by simplifying the vector-add transform script and adjusting how the optional transform script path is passed into config_context().
Changes:
- Refactor
vecadd_aie2.mlirto usetransform.includecalls to shared transform-library sequences instead of inlining all transform steps. - Update
build_triton.pyto passdataclasses.MISSINGas the default sentinel fortransform_tiling_script(replacing the previous_UNSETusage).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ggml-hsa/kernels/triton/vecadd_aie2.mlir |
Switches vecadd AIE2 transform pipeline to shared transform.include sequences for newer Triton-XDNA flows. |
src/ggml-hsa/kernels/build_triton.py |
Updates config_context() invocation to use MISSING as the “not provided” default for transform_tiling_script. |
ypapadop-amd
added a commit
that referenced
this pull request
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.