Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use const_format and provide version as static str #265

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Jan 7, 2025

What type of PR is this?

/kind api-change

What this PR does / why we need it:

This PR is a slight change that makes version available as a &'static str instead of String.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

This PR does not bump the crate version. Although it doesn't contain any breaking changes, and it adds a deprecation for the old API.

I suggest a minor version bump.

Does this PR introduce a user-facing change?

Expose version as `&'static str` instead of `String`; the old way of getting the version is still available for now, but marked as deprecated.

src/distribution/version.rs Outdated Show resolved Hide resolved
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Jan 7, 2025

Merge it?

@flavio flavio merged commit 756cb6f into youki-dev:main Jan 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants