fix: apply review-recommended fixes for 2.3.0

MIGRATION.md

@@ -1,4 +1,47 @@
-# Migration Guide: 1.x to 2.0
+# Migration Guide
+
+## 1.x → 2.3.0 (Latest)
+
+This guide covers breaking changes introduced in 2.3.0. If you are upgrading from 1.x, also read the [1.x → 2.0](#1x-to-20) section below.
+
+### Breaking Changes in 2.3.0
+
+#### Python 3.10 now required
+
+The minimum supported Python version has been raised from `>=3.9.2` to `>=3.10`. If you are running Python 3.9, you must upgrade before installing this version.
+
+```bash
+python --version   # must be 3.10 or later
+pip install "youdotcom>=2.3.0"
+```
+
+#### Search API: `count` default changed
+
+`you.search.unified()` now defaults `count` to `10` (previously `None`/no default). If your code omits `count` and relies on the API-server default, you will now always receive 10 results.
+
+```python
+# Before (2.x < 2.3.0): count was unset, server decided
+res = you.search.unified(query="AI news")
+
+# After (2.3.0+): equivalent explicit call
+res = you.search.unified(query="AI news", count=10)
+```
+
+#### Contents API: `crawl_timeout` type changed
+
+`crawl_timeout` has changed from `float` to `int`. Passing a float (e.g., `crawl_timeout=5.5`) will now raise a validation error.
+
+```python
+# Before: float was accepted
+res = you.contents.generate(urls=["https://example.com"], crawl_timeout=5.5)
+
+# After: use int
+res = you.contents.generate(urls=["https://example.com"], crawl_timeout=5)
+```
+
+---
+
+## 1.x to 2.0
 
 This guide helps you upgrade your code from You.com Python SDK 1.x to 2.0.
 

README.md

@@ -239,6 +239,18 @@ underlying connection when the context is exited.
 ```python
 import os
 from youdotcom import You
+from youdotcom.models import (
+    ExpressAgentRunsRequest,
+    WebSearchTool,
+    ResponseCreated,
+    ResponseStarting,
+    ResponseOutputItemAdded,
+    ResponseOutputContentFull,
+    ResponseOutputTextDelta,
+    ResponseOutputItemDone,
+    ResponseDone,
+)
+from youdotcom.utils import eventstreaming
 
 
 with You(
@@ -287,7 +299,7 @@ with You(
 
             elif isinstance(event_data, ResponseDone):
                 print("\n🎉 Response completed!")
-                print(f"   Runtime: {event_data.response.run_time_ms} seconds")
+                print(f"   Runtime: {event_data.response.run_time_ms} ms")
                 print(f"   Finished: {event_data.response.finished}")
 
             else:

src/youdotcom/sdkconfiguration.py

@@ -8,8 +8,7 @@
 )
 from .httpclient import AsyncHttpClient, HttpClient
 from .utils import Logger, RetryConfig, remove_suffix
-from dataclasses import dataclass
-from pydantic import Field
+from dataclasses import dataclass, field
 from typing import Callable, Dict, Optional, Tuple, Union
 from youdotcom import models
 from youdotcom.types import OptionalNullable, UNSET
@@ -36,7 +35,7 @@ class SDKConfiguration:
     sdk_version: str = __version__
     gen_version: str = __gen_version__
     user_agent: str = __user_agent__
-    retry_config: OptionalNullable[RetryConfig] = Field(default_factory=lambda: UNSET)
+    retry_config: OptionalNullable[RetryConfig] = field(default_factory=lambda: UNSET)
     timeout_ms: Optional[int] = None
 
     def get_server_details(self) -> Tuple[str, Dict[str, str]]:

src/youdotcom/utils/retries.py

@@ -145,10 +145,10 @@ def do_request() -> httpx.Response:
                         if res.status_code == parsed_code:
                             raise TemporaryError(res)
             except (httpx.NetworkError, httpx.TimeoutException) as exception:
-                if retries.config.retry_connection_errors:
-                    raise
+                if not retries.config.retry_connection_errors:
+                    raise PermanentError(exception) from exception
 
-                raise PermanentError(exception) from exception
+                raise
             except TemporaryError:
                 raise
             except Exception as exception:
@@ -189,10 +189,10 @@ async def do_request() -> httpx.Response:
                         if res.status_code == parsed_code:
                             raise TemporaryError(res)
             except (httpx.NetworkError, httpx.TimeoutException) as exception:
-                if retries.config.retry_connection_errors:
-                    raise
+                if not retries.config.retry_connection_errors:
+                    raise PermanentError(exception) from exception
 
-                raise PermanentError(exception) from exception
+                raise
             except TemporaryError:
                 raise
             except Exception as exception:
@@ -229,9 +229,6 @@ def retry_with_backoff(
         except Exception as exception:  # pylint: disable=broad-exception-caught
             now = round(time.time() * 1000)
             if now - start > max_elapsed_time:
-                if isinstance(exception, TemporaryError):
-                    return exception.response
-
                 raise
 
             sleep = _get_sleep_interval(
@@ -259,9 +256,6 @@ async def retry_with_backoff_async(
         except Exception as exception:  # pylint: disable=broad-exception-caught
             now = round(time.time() * 1000)
             if now - start > max_elapsed_time:
-                if isinstance(exception, TemporaryError):
-                    return exception.response
-
                 raise
 
             sleep = _get_sleep_interval(

src/youdotcom/utils/security.py

@@ -144,7 +144,7 @@ def _parse_security_scheme_value(
         elif sub_type == "query":
             query_params[header_name] = [value]
         else:
-            raise ValueError("sub type {sub_type} not supported")
+            raise ValueError(f"sub type {sub_type} not supported")
     elif scheme_type == "openIdConnect":
         headers[header_name] = _apply_bearer(value)
     elif scheme_type == "oauth2":
@@ -158,9 +158,9 @@ def _parse_security_scheme_value(
         elif sub_type == "custom":
             return
         else:
-            raise ValueError("sub type {sub_type} not supported")
+            raise ValueError(f"sub type {sub_type} not supported")
     else:
-        raise ValueError("scheme type {scheme_type} not supported")
+        raise ValueError(f"scheme type {scheme_type} not supported")
 
 
 def _apply_bearer(token: str) -> str:

tests/test_research.py

@@ -70,9 +70,10 @@ def test_research_with_sources(self, server_url, api_key):
 
             assert isinstance(res, ResearchResponse)
             assert res.output is not None
-            if res.output.sources:
-                for source in res.output.sources:
-                    assert source.url is not None
+            assert res.output.sources is not None
+            assert len(res.output.sources) > 0
+            for source in res.output.sources:
+                assert source.url is not None
 
 
 class TestResearchAsync:
@@ -96,6 +97,7 @@ async def test_basic_research_async(self, server_url, api_key):
             assert isinstance(res, ResearchResponse)
             assert res.output is not None
             assert res.output.content is not None
+            assert len(res.output.content) > 0
 
 
 class TestResearchErrors: