spanner: parallelize session creation #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnorberg
force-pushed
the
dano/spanner-parallel-session-creation
branch
from
a284e84 to
04c86d6
Compare
danielnorberg
commented
Dec 22, 2024
| for _ in 0..channel_num { | ||
| // Ensure that we create the exact number of requested sessions by adding the remainder to the first channel. |
There was a problem hiding this comment.
Also took the opportunity to implement the same exact session creation as the golang client: https://github.com/googleapis/google-cloud-go/blob/7cbffad749a0f8917658406dae73c7fb7151b55d/spanner/sessionclient.go#L221
Ran into this during testing when creating a client where channel_num > min_opened.
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallelize spanner session creation as proposed in #323 (comment)