Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: gar list functions to return responses structs #210

Merged
merged 1 commit into from
Nov 20, 2023
Merged

chore: gar list functions to return responses structs #210

merged 1 commit into from
Nov 20, 2023

Conversation

benjaminch
Copy link
Contributor

List functions to return *Response objects rather than object vector allowing caller to handle pagination.

@benjaminch
chore: gar list functions to return responses structs
3a8473a 
List functions to return `*Response` objects rather than object vector
allowing caller to handle pagination.
@benjaminch
Copy link
Contributor Author

Hey @yoshidan sorry about this one, but figured out that handling list_ functions is better with response objects rather than object vec because it allows client to handle pagination.

@yoshidan yoshidan added the safe to test safe to test label Nov 20, 2023
@yoshidan yoshidan merged commit 63d6c79 into yoshidan:main Nov 20, 2023
5 checks passed
@benjaminch
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
safe to test safe to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminch @yoshidan