feat: support artifact registry #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminch
force-pushed
the
feat/support-artifact-registry
branch
from
ce81631 to
0bb663a
Compare
yoshidan
reviewed
Nov 16, 2023
|
Thanks for review @yoshidan, pushed a patch with fixes :) |
benjaminch
force-pushed
the
feat/support-artifact-registry
branch
from
795dee5 to
4eb9cf5
Compare
benjaminch
force-pushed
the
feat/support-artifact-registry
branch
from
4eb9cf5 to
884281d
Compare
|
Hi @yoshidan ! Should I add Artifact registry to the CI? Totally forgot. .github/workflows/ci.yaml |
|
I will add the CI for artifact registry. |
|
Thanks a lot 😉 |
|
Would you mind creating a new release with this change? |
|
I will publish crate after adding CI. Please wait a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft version adding support for Google Artifact registry.
Can you let me know what you think about it? I focused on registry + docker images in the examples.
Issue: #208