Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed google-cloud-auth dependency from other crates. #105

Merged
merged 31 commits into from
Feb 14, 2023
Merged

Conversation

yoshidan
Copy link
Owner

@yoshidan yoshidan commented Feb 10, 2023

  • I made google-cloud-auth optional to use google-cloud-spanner, google-cloud-pubsub and google-cloud-storage.

  • I added the google-cloud-token crate.

    • This crate provides TokenSourceProvider, which is minimal trait to get authentication token.
    • To implements TokenSourceProvider makes you to use your own auth crate.
    • google-cloud-auth also implements TokenSourceProvider DefaultTokenSourceProvider
  • We can use google-cloud-default to use google-cloud-auth.

    • This crate provides default implementation forClientConfig

Here is the pubsub example to use google-cloud-default.

use google_cloud_default::WithAuthExt;
use google_cloud_pubsub::client::{Client, ClientConfig};

let config = ClientConfig::default().with_auth().await.unwrap();
let client = Client::new(config).await.unwrap();

Other Changes

Spanner

  • Removed anyhow crate and merged TxError, InitializationError and RunInTxError into simple Error

ref #92 #99 #101

@yoshidan yoshidan marked this pull request as ready for review February 13, 2023 10:04
@yoshidan yoshidan added the safe to test safe to test label Feb 13, 2023
@yoshidan yoshidan added safe to test safe to test and removed safe to test safe to test labels Feb 14, 2023
@yoshidan yoshidan merged commit 24a292a into main Feb 14, 2023
@yoshidan yoshidan deleted the issue98_99_101 branch February 14, 2023 01:46
@fredr fredr mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant