Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify idpool to fix potential memory leak issue #70

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Simplify idpool to fix potential memory leak issue #70

merged 3 commits into from
Feb 19, 2021

Conversation

yookoala
Copy link
Owner

@yookoala yookoala commented Feb 18, 2021 •
edited
Loading

@yookoala yookoala force-pushed the fix/idpool branch 2 times, most recently from 8c1133d to 83631cd Compare February 19, 2021 19:04
@mpdroog @yookoala
client: simplfy idPool to prevent memory leak
4663d83 
* Replaced go-routine impl with lock to simplify
  the code and solve the leaking.
@yookoala
travis: Remove go 1.7 and 1.8 from test
f4daef5 
* Using sync.Map for idPool. The feature is only available on
  go 1.9 and after. So go 1.7 and 1.8 are droped out of support.
@yookoala
BREAKING: Changed SimpleClientFactory function signature
4ea507d 
* Remove the new obsoleted limit argument. No longer support in
  the new idPool implementation. Please discuss in issue track
  if you want this back.
@yookoala yookoala merged commit 33ba70c into master Feb 19, 2021
@yookoala yookoala deleted the fix/idpool branch February 19, 2021 19:23
This was referenced Feb 19, 2021
Closed
Open
Closed
Closed
@ruudk
Copy link
Contributor

ruudk commented Feb 19, 2021

Thanks for this PR! 💙

I'll test it out next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yookoala @ruudk @mpdroog