Allow lookup template attributes from globalTemplateAttributes

Docs/ProjectSpec.md

@@ -35,6 +35,7 @@ You can also use environment variables in your configuration file, by using `${S
   - [Legacy Target](#legacy-target)
 - [Aggregate Target](#aggregate-target)
 - [Target Template](#target-template)
+- [Global Template Attributes](#global-template-attributes)
 - [Scheme](#scheme)
   - [Build](#build)
   - [Common Build Action options](#common-build-action-options)
@@ -973,6 +974,15 @@ targetTemplates:
       - ${frameworkName}/${target_name}
 ```
 
+## Global template attributes
+
+This is place to define global variables used to resolve missing `${target_name}` within each template. This also helps share attributes between yaml files.
+
+```yaml
+globalTemplateAttributes:
+  version: legacy
+```
+
 ## Scheme
 
 Schemes allows for more control than the convenience [Target Scheme](#target-scheme) on [Target](#target)

Sources/ProjectSpec/Template.swift

@@ -66,6 +66,10 @@ private func resolveTemplates(jsonDictionary: JSONDictionary, templateStructure:
             if let templateAttributes = reference["templateAttributes"] as? [String: String] {
                 reference = reference.expand(variables: templateAttributes)
             }
+
+            if let globalVariables = jsonDictionary["globalTemplateAttributes"] as? [String: String] {
+                reference = reference.expand(variables: globalVariables)
+            }
         }
         baseDictionary[referenceName] = reference
     }

Tests/Fixtures/TestProject/ContentBlocker/Configs/legacy/Debug.xcconfig

@@ -0,0 +1 @@
+API_PATH = https://dev.google.com

Tests/Fixtures/TestProject/ContentBlocker/Configs/legacy/Release.xcconfig

@@ -0,0 +1 @@
+API_PATH = https://release.google.com

Tests/Fixtures/TestProject/ContentBlocker/ContentBlockerRequestHandler.swift

@@ -0,0 +1,15 @@
+import UIKit
+import MobileCoreServices
+
+class ContentBlockerRequestHandler: NSObject, NSExtensionRequestHandling {
+
+    func beginRequest(with context: NSExtensionContext) {
+        let attachment = NSItemProvider(contentsOf: Bundle.main.url(forResource: "blockerList", withExtension: "json"))!
+
+        let item = NSExtensionItem()
+        item.attachments = [attachment]
+
+        context.completeRequest(returningItems: [item], completionHandler: nil)
+    }
+
+}

Tests/Fixtures/TestProject/ContentBlocker/Info.plist

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>NSExtension</key>
+	<dict>
+		<key>NSExtensionPointIdentifier</key>
+		<string>com.apple.Safari.content-blocker</string>
+		<key>NSExtensionPrincipalClass</key>
+		<string>$(PRODUCT_MODULE_NAME).ContentBlockerRequestHandler</string>
+	</dict>
+</dict>
+</plist>

Tests/Fixtures/TestProject/ContentBlocker/blockerList.json

@@ -0,0 +1,10 @@
+[
+    {
+        "action": {
+            "type": "block"
+        },
+        "trigger": {
+            "url-filter": "webkit.svg"
+        }
+    }
+]

Tests/Fixtures/TestProject/project.yml

@@ -16,6 +16,8 @@ options:
       buildPhase: none
     abcd:
       buildPhase: none
+globalTemplateAttributes:
+  version: legacy
 fileGroups:
   - Configs
   - FileGroup
@@ -79,7 +81,9 @@ targets:
     legacy:
       toolPath: /usr/bin/true
       passSettings: true
-
+  ContentBlocker:
+    templates:
+      - ContentBlockerTemplate
   App_macOS:
     type: application
     platform: macOS
@@ -520,6 +524,20 @@ schemes:
 targetTemplates:
   MyTemplate:
     scheme: {}
+  ContentBlockerTemplate:
+    platform: iOS
+    type: app-extension
+    settings:
+      CODE_SIGN_IDENTITY: Apple Development
+    configFiles:
+      Test Debug: ContentBlocker/Configs/${version}/Debug.xcconfig
+      Staging Debug: ContentBlocker/Configs/${version}/Debug.xcconfig
+      Production Debug: ContentBlocker/Configs/${version}/Debug.xcconfig
+      Test Release: ContentBlocker/Configs/${version}/Release.xcconfig
+      Staging Release: ContentBlocker/Configs/${version}/Release.xcconfig
+      Production Release: ContentBlocker/Configs/${version}/Release.xcconfig
+    sources:
+      - ContentBlocker
 aggregateTargets:
   SuperTarget:
     attributes:

Tests/Fixtures/global_template_attributes_test.yml

@@ -0,0 +1,32 @@
+targetTemplates:
+  ContentBlockerTemplate:
+    platform: iOS
+    type: app-extension
+    settings:
+      CODE_SIGN_IDENTITY: Apple Development
+    configFiles:
+      Test Debug: ContentBlocker/Configs/${version}/Debug.xcconfig
+      Staging Debug: ContentBlocker/Configs/${version}/Debug.xcconfig
+      Production Debug: ContentBlocker/Configs/${version}/Debug.xcconfig
+      Test Release: ContentBlocker/Configs/${version}/Release.xcconfig
+      Staging Release: ContentBlocker/Configs/${version}/Release.xcconfig
+      Production Release: ContentBlocker/Configs/${version}/Release.xcconfig
+    sources:
+      - ContentBlocker
+
+globalTemplateAttributes:
+  version: legacy
+
+name: Demo
+options:
+  createIntermediateGroups: True
+targets:
+  Demo:
+    type: application
+    platform: iOS
+    deploymentTarget: "10.0"
+    sources:
+      - DemoXcodeGenGlobalTemplateAttribute
+  ContentBlocker:
+    templates:
+      - ContentBlockerTemplate

Tests/ProjectSpecTests/SpecLoadingTests.swift

@@ -285,6 +285,15 @@ class SpecLoadingTests: XCTestCase {
                 ]
                 try expect(project.targets.last?.sources) == ["SomeTarget", "doesWin", "templateVariable"]
             }
+
+            $0.it("lookup global template attributes") {
+                let path = fixturePath + "global_template_attributes_test.yml"
+
+                let project = try loadSpec(path: path)
+                let extensionTarget = project.targets.first!
+                try expect(extensionTarget.configFiles["Production Debug"]) == "ContentBlocker/Configs/legacy/Debug.xcconfig"
+                try expect(extensionTarget.configFiles["Production Release"]) == "ContentBlocker/Configs/legacy/Release.xcconfig"
+            }
         }
     }