Adding docker resources limits and reservations for celery#1434
Closed
null-ref-0000 wants to merge 1 commit intoyogeshojha:masterfrom
Closed
Adding docker resources limits and reservations for celery#1434null-ref-0000 wants to merge 1 commit intoyogeshojha:masterfrom
null-ref-0000 wants to merge 1 commit intoyogeshojha:masterfrom
Conversation
Contributor
|
Woohoo @null-ref-0000! 🎉 You've just dropped some hot new code! 🔥 Hang tight while we review this! You rock! 🤘 |
Contributor
Author
Contributor
|
Hey, thanks for your contribution! 🙏 We appreciate the time and effort you put into this PR. Sadly this is not the right fit for reNgine at the moment. While we couldn't merge it this time, we value your interest in improving reNgine. Feel free to reach out if you have any questions. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request sets resource limits on celery for cpu and memory. In addition its sets resource reservation on celery for cpu and memory. This avoids the issue of celery causing out of memory issues on the machine. This pull request does not set resource limit or reservations on any other services, but we should likely consider it. By default Docker set the max limit to mem or cpu available on the machine for all containers, but celery end up always being killed due to it consume almost all of the memory on the machine.
Reference:
https://docs.docker.com/reference/compose-file/deploy/#resources