fix: drop AttachGuard only after all GlobalRefs in JReaderInputStream are dropped #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the library!
When using the Streams for text extraction,
GlobalRef
s are dropped after the thread is already detached from the VM. This leads to a warning from jni crate:I fixed this by including the
AttachGuard
in theJReaderInputStream
struct, so that the thread is detached only after all GlobalRefs in it are dropped.(also, the tagged v0.3.0 commit is not part of any branch in this repository and main is outdated)