Skip to content

Fix mobile example wrapping - #49

Merged
yoavf merged 4 commits into
mainfrom
agent/fix-mobile-example-wrapping
Aug 19, 2026
Merged

Fix mobile example wrapping#49
yoavf merged 4 commits into
mainfrom
agent/fix-mobile-example-wrapping

Conversation

@yoavf

@yoavf yoavf commented Aug 19, 2026

Copy link
Copy Markdown
Owner

What changed

Mobile command examples now wrap instead of requiring horizontal scrolling. Long command fragments can break safely, and connector paths are hidden on narrow screens while text-pair highlights remain.

Why

The hero examples used single-line, horizontally scrollable terminal rows, which left request text and translations cut off on mobile screens.

Impact

Mobile visitors can read complete example requests and generated commands without needing to discover horizontal scrolling.

Validation

  • npm run test:demo (31 passing)
  • git diff --check

Greptile Summary

Mobile terminal examples now wrap long request and result text, while the cursor remains in the request flow and connector paths are hidden at narrow widths.

  • Moves the cursor inside the request code element and preserves it across rendering paths.
  • Adds responsive wrapping styles and mobile terminal sizing.
  • Updates browser asset cache versions and corresponding configuration assertions.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported wrapped-cursor issue is fixed because every preview rendering path places the cursor after the request content.

Important Files Changed

Filename Overview
docs/index.html Nests the cursor in the request text flow and updates stylesheet and script cache versions.
docs/script.js Keeps the singleton cursor as the final request child during animated, static, and reduced-motion example rendering.
docs/styles.css Enables mobile command wrapping, hides connector paths at narrow widths, and aligns the inline cursor with wrapped text.
site/demo-config.test.js Updates cache-version assertions to match the revised page assets.

Reviews (2): Last reviewed commit: "Keep cursor with wrapped request" | Re-trigger Greptile

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 19, 2026

Copy link
Copy Markdown

Deploying jst with  Cloudflare Pages  Cloudflare Pages

Latest commit: fe7a370
Status: ✅  Deploy successful!
Preview URL: https://b08c5ad8.jst-5mg.pages.dev
Branch Preview URL: https://agent-fix-mobile-example-wra.jst-5mg.pages.dev

View logs

@yoavf
yoavf marked this pull request as ready for review August 19, 2026 08:04
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix mobile command example wrapping

🐞 Bug fix 🕐 Less than 10 minutes

Grey Divider

AI Description

• Wraps mobile request and command examples instead of requiring horizontal scrolling.
• Preserves highlight pairing while hiding misleading connector paths on narrow screens.
• Reserves mobile translation height and refreshes the stylesheet cache key.
Diagram

graph TD
  A["Mobile Browser"] --> B["Landing Page"] --> C["Versioned Styles"] --> D["Mobile Rules"] --> E["Wrapped Commands"]
  D --> F["Stable Panel"]
  D --> G["Hidden Connectors"]
Loading
High-Level Assessment

The responsive media-query approach is appropriate because this is purely presentational behavior and requires no runtime viewport logic. Retaining horizontal scrolling would preserve connector geometry but leave content undiscoverable, while JavaScript-driven layout handling would add unnecessary complexity.

Files changed (2) +21 / -1

Bug fix (1) +20 / -0
styles.cssWrap terminal examples on mobile screens +20/-0

Wrap terminal examples on mobile screens

• Updates narrow-screen terminal rows and result fragments to wrap long command text instead of scrolling horizontally. Reserves translation panel height and hides connector paths whose geometry becomes unclear after wrapping.

docs/styles.css

Other (1) +1 / -1
index.htmlRefresh the documentation stylesheet cache key +1/-1

Refresh the documentation stylesheet cache key

• Bumps the stylesheet query version from 25 to 27 so browsers retrieve the responsive wrapping fixes.

docs/index.html

@yoavf
yoavf force-pushed the agent/fix-mobile-example-wrapping branch from adab8b0 to 342cee0 Compare August 19, 2026 08:06
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread docs/styles.css
@yoavf
yoavf merged commit 391439a into main Aug 19, 2026
5 checks passed
@yoavf
yoavf deleted the agent/fix-mobile-example-wrapping branch August 19, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant