Skip to content

Skip PR previews for website-only changes - #48

Merged
yoavf merged 1 commit into
mainfrom
agent/skip-website-pr-preview-builds
Aug 18, 2026
Merged

Skip PR previews for website-only changes#48
yoavf merged 1 commit into
mainfrom
agent/skip-website-pr-preview-builds

Conversation

@yoavf

@yoavf yoavf commented Aug 18, 2026

Copy link
Copy Markdown
Owner

What changed

  • Ignore changes under site/** in the macOS PR preview workflow.
  • Ignore the website's root npm manifests and Vite configuration.
  • Preserve preview builds for PRs that also modify CLI-related files.

Why

The workflow previously ignored only the generated/deployed docs/** tree. Website source changes live under site/** and use the root npm/Vite files, so website-only PRs still created an unnecessary macOS CLI artifact.

Impact

Website-only PRs no longer consume a macOS runner to produce an unrelated CLI preview build.

Validation

  • Parsed .github/workflows/pr-preview.yml successfully as YAML.
  • Ran git diff --check.

Greptile Summary

The PR prevents the macOS CLI preview workflow from running when a pull request changes only website-related files.

  • Adds site/** to the workflow’s ignored paths.
  • Adds the website’s root npm manifests and Vite configuration.
  • Retains preview builds when any non-ignored, CLI-related file is also changed.

Confidence Score: 5/5

The PR appears safe to merge because the newly ignored paths are website-only and mixed pull requests containing CLI changes still trigger the preview workflow.

The preview build invokes the Cargo-based macOS release script and does not consume site/**, the npm manifests, or Vite configuration, so suppressing runs for changes limited to those paths does not omit a relevant CLI artifact.

Important Files Changed

Filename Overview
.github/workflows/pr-preview.yml Adds website-only paths to pull_request.paths-ignore; the ignored files are not inputs to the Cargo-based CLI preview build.

Reviews (1): Last reviewed commit: "Skip PR previews for website-only change..." | Re-trigger Greptile

@yoavf
yoavf marked this pull request as ready for review August 18, 2026 19:13
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Skip macOS PR previews for website-only changes

⚙️ Configuration changes ✨ Enhancement 🕐 Less than 5 minutes

Grey Divider

AI Description

• Excludes website sources and root frontend configuration from macOS PR preview triggers.
• Keeps CLI preview builds active when pull requests include non-website changes.
High-Level Assessment

Using pull_request.paths-ignore is the simplest and most appropriate approach because it prevents website-only changes from allocating a macOS runner while GitHub still triggers the workflow when any non-ignored CLI-related file changes.

Files changed (1) +4 / -0

Other (1) +4 / -0
pr-preview.ymlExclude website-only changes from PR preview builds +4/-0

Exclude website-only changes from PR preview builds

• Adds the website source tree, root npm manifests, and Vite configuration to the ignored pull-request paths. Mixed pull requests containing non-ignored CLI changes continue to trigger the macOS preview build.

.github/workflows/pr-preview.yml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can keep summaries lean with Finding overflow, which tucks the rest behind 'View more'

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@github-actions

Copy link
Copy Markdown

The macOS CLI preview for this PR is ready. With GitHub CLI authenticated, copy this one command to download and run it:

preview_dir="$(mktemp -d)" && gh run download 32175310680 --repo yoavf/jst --name jst-pr-preview-macos-universal --dir "$preview_dir" && chmod +x "$preview_dir/jst" && "$preview_dir/jst" --dry list files in the current directory

Replace the example arguments after jst to test another command. The artifact is retained for 7 days.

View the preview build

@yoavf
yoavf merged commit 0678b1d into main Aug 18, 2026
6 checks passed
@yoavf
yoavf deleted the agent/skip-website-pr-preview-builds branch August 18, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant