Skip PR previews for website-only changes - #48
Merged
Conversation
yoavf
marked this pull request as ready for review
August 18, 2026 19:13
PR Summary by QodoSkip macOS PR previews for website-only changes
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can keep summaries lean with Finding overflow, which tucks the rest behind 'View more' |
|
The macOS CLI preview for this PR is ready. With GitHub CLI authenticated, copy this one command to download and run it: preview_dir="$(mktemp -d)" && gh run download 32175310680 --repo yoavf/jst --name jst-pr-preview-macos-universal --dir "$preview_dir" && chmod +x "$preview_dir/jst" && "$preview_dir/jst" --dry list files in the current directoryReplace the example arguments after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
site/**in the macOS PR preview workflow.Why
The workflow previously ignored only the generated/deployed
docs/**tree. Website source changes live undersite/**and use the root npm/Vite files, so website-only PRs still created an unnecessary macOS CLI artifact.Impact
Website-only PRs no longer consume a macOS runner to produce an unrelated CLI preview build.
Validation
.github/workflows/pr-preview.ymlsuccessfully as YAML.git diff --check.Greptile Summary
The PR prevents the macOS CLI preview workflow from running when a pull request changes only website-related files.
site/**to the workflow’s ignored paths.Confidence Score: 5/5
The PR appears safe to merge because the newly ignored paths are website-only and mixed pull requests containing CLI changes still trigger the preview workflow.
The preview build invokes the Cargo-based macOS release script and does not consume
site/**, the npm manifests, or Vite configuration, so suppressing runs for changes limited to those paths does not omit a relevant CLI artifact.Important Files Changed
pull_request.paths-ignore; the ignored files are not inputs to the Cargo-based CLI preview build.Reviews (1): Last reviewed commit: "Skip PR previews for website-only change..." | Re-trigger Greptile