Skip to content

Prevent trying to open too many connections to the server when the server is closing the websocket on its own #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent trying to open too many connections to the server when the server is closing the websocket on its own #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/y-websocket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,20 +113,23 @@ const setupWS = provider => {
provider.emit('status', [{
status: 'disconnected'
}])
} else {
provider.wsUnsuccessfulReconnects++
clearTimeout(provider.resetUnsuccessfulReconnects)
}

// Start with no reconnect timeout and increase timeout by
// log10(wsUnsuccessfulReconnects).
// The idea is to increase reconnect timeout slowly and have no reconnect
// timeout at the beginning (log(1) = 0)
provider.wsUnsuccessfulReconnects++
setTimeout(setupWS, math.min(math.log10(provider.wsUnsuccessfulReconnects + 1) * reconnectTimeoutBase, maxReconnectTimeout), provider)
}
websocket.onopen = () => {
provider.wsLastMessageReceived = time.getUnixTime()
provider.wsconnecting = false
provider.wsconnected = true
provider.wsUnsuccessfulReconnects = 0
provider.resetUnsuccessfulReconnects = setTimeout(() => {
provider.wsUnsuccessfulReconnects = 0
}, 1000)
provider.emit('status', [{
status: 'connected'
}])
Expand Down Expand Up @@ -207,6 +210,7 @@ export class WebsocketProvider extends Observable {
this.wsconnecting = false
this.bcconnected = false
this.wsUnsuccessfulReconnects = 0
this.resetUnsuccessfulReconnects = undefined
this.messageHandlers = messageHandlers.slice()
this.mux = mutex.createMutex()
/**
Expand Down