Repository navigation
Fix #161: Throw InvalidArgumentException with a clear message when an empty view name is passed to WebViewRenderer render methods - #161
Merged
Conversation
An empty view name has nothing to render. Without a view path it failed with "The view path is not set.", and with one with "The view file ".../.php" does not exist.", and only once the response body was read. The render methods now throw InvalidArgumentException right away, with a message that points to a response factory for responses without a view, such as JSON.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 171 173 +2
===========================================
Files 11 11
Lines 511 518 +7
===========================================
+ Hits 511 518 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vjik
approved these changes
Oct 29, 2026
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
samdark
changed the title
InvalidArgumentException with a clear message when an empty view name is passed to WebViewRenderer render methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to yiisoft/app#478.
An empty view name has nothing to render, but
WebViewRendererdidn't say so. Without a view path it failed with "The view path is not set.", and with one with "The view file ".../.php" does not exist.". Forrender()andrenderPartial()this happened only when the response body was read, away from the call that caused it.render(),renderPartial(),renderAsString()andrenderPartialAsString()now throwInvalidArgumentExceptionright away when the view name is empty. The message says that a response without a view, such as JSON, should be created with a response factory.The deprecated
ViewRendereris unchanged.