-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a discord adapter #223
Conversation
@@ -104,10 +104,12 @@ | |||
; chat protocols | |||
[irclj "0.5.0-alpha4"] | |||
;; use this fork which uses javax.websockets for compatability with Yetibot | |||
[stylefruits/gniazdo-jsr356 "1.0.0"] | |||
;; gniazdo 1.2.2 needed for discljord | |||
[stylefruits/gniazdo "1.2.2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to update this for discord to work properly. I'm thinking this will end up breaking other things since this uses jetty
's Websocket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like your local yb is running just fine? I'll do some more testing but this upgrade might be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah locally it is fine. I didn't test any other connectors though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to include this dep in the the yetibot/yetibot
project.clj as well to get it to run properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed slack still works with this upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sick. Thanks for checking that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -104,10 +104,12 @@ | |||
; chat protocols | |||
[irclj "0.5.0-alpha4"] | |||
;; use this fork which uses javax.websockets for compatability with Yetibot | |||
[stylefruits/gniazdo-jsr356 "1.0.0"] | |||
;; gniazdo 1.2.2 needed for discljord | |||
[stylefruits/gniazdo "1.2.2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like your local yb is running just fine? I'll do some more testing but this upgrade might be good to go.
Note: adapters now pass the raw event in the chat-source so cmd handlers can optionally use platform-specific stuff, so we should do that for discord as well, e.g. https://github.com/yetibot/core/pull/224/files#diff-1a12310cc4d4bb44655929798120810eab79f8ad290cb8e65a3605d8fc3a34f0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:sick:
Co-authored-by: Trevor Hartman <[email protected]>
Task:
Getting a discord adapter implemented.
I'm using the library from discljord to implement a lot of this.
Todo before merging: