-
Notifications
You must be signed in to change notification settings - Fork 381
fix(aggregation_mode): hardcode image_id and vk_hash from solidity contract #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
// Write to the file | ||
fs::write( | ||
&dest_path, | ||
serde_json::to_string_pretty(&json_data).unwrap(), | ||
) | ||
.unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also considered printing it to the console instead of writing it to a file, as this is only available in the contracts deployment configs.
Co-authored-by: Julian Arce <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should re review the hashes after deterministic compiling gets added on this PR for Risc0 (SP1 is already merged)
The program ids with the new builds have been updated: cdf6342. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
I added to the anvil_deploy_aligned_contracts
the step to update the program_ids and fixed the install_aggregation_mode
target
Description
image_id
andvk_hash
as input parameters. Instead, these values are now stored in the contract’s storage and can only be modified by the contract owner.Also, a new CLI binary was added to export the image_id and vk_hash to a JSON file to simplify the process of managing and registering valid programs.
How to test
Run the proof aggregator with proving and verify that it works:
make start_proof_aggregator AGGREGATOR=sp1
make start_proof_aggregator AGGREGATOR=risc0
Type of change
Checklist
testnet
, everything else tostaging