Skip to content

feat(aggregation_mode): aggregate proofs in chunks #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: staging
Choose a base branch
from
Open

feat(aggregation_mode): aggregate proofs in chunks #1896

wants to merge 36 commits into from

Conversation

MarcosNicolau
Copy link
Member

@MarcosNicolau MarcosNicolau commented Apr 25, 2025 •
edited
Loading

Description

Split the aggregation of proofs in chunks of 512 items.

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau
feat: risc0 aggregation program
3200e0c
@MarcosNicolau
feat: [wip] risc0 aggregator backend
2f54502
@MarcosNicolau
feat: ProofAggregationService risc0 verification
62bfb60
@MarcosNicolau
feat: error handling + fetch risc0 proofs
c475a63
@MarcosNicolau
feat: send risc0 aggregated proof to AlignedProofAggregationService c…
e2dcf30 
…ontract
@MarcosNicolau
feat: deploy AlignedProofAggregationService contract with risc0 verifier
1c4440b
@MarcosNicolau
feat: allow risc0 succinct proofs
df1d83a
@MarcosNicolau
chore: modified risc0 no_pub_inputs to generate a succinct proof inst…
4bc1a52 
…ead of a composite
@MarcosNicolau
feat: fetch proofs based on zkvm engine
56a9d87
@MarcosNicolau
chore: commands to start proof agregator based on verifier
6c544d0
@MarcosNicolau
fix: compute image id bytes in little endian not in be
b137020
@MarcosNicolau
feat: local verification of aggregated risc0 proof
d0a4be6
@MarcosNicolau
Merge branch 'staging' into feat/aggregation-mode-risc0
8309ea8
@MarcosNicolau
chore: add gpu feature flag to run with cuda
369cdc6
@MarcosNicolau
docs: add gpu command
7720553
@MarcosNicolau
chore: undo no_pub_input file changes
ebdc910
@MarcosNicolau
ci: fix contracts build + install risc0 toolchain
1b8873a
@MarcosNicolau
chore: better proof aggregator makefile targets
01f60f4
@MarcosNicolau
docs: update how to run proof aggregator readme
20b7d61
@MarcosNicolau
ci: skip build on clippy
454f80c
@MarcosNicolau
chore: address clippy warnings
5e43630
@MarcosNicolau
fix: correctly setting risc0 tiny-keccak patch
79eb6b3
@MarcosNicolau
chore: rename prove feature to proving to prevent collision with risc…
bd5ad9d 
…0 features
@MarcosNicolau
Revert "chore: rename prove feature to proving to prevent collision w…
ef2b968 
…ith risc0 features"

This reverts commit bd5ad9d.
@MarcosNicolau
chore: address juli's comments
319c112
@MarcosNicolau
refactor: replace sp1,risc0 features for .env variables
ac646c6
@MarcosNicolau
chore: update makefile for new aggregator env config
74f15be
@MarcosNicolau
refactor: aggregation mode reduce amount of types and abstractions
b63e875
@MarcosNicolau
Merge branch 'staging' into refactor/agg-mode-redundancies
02987a4
@MarcosNicolau
feat: aggregate proofs in chunks of 512 proofs
4059b2c
@MarcosNicolau MarcosNicolau changed the title Feat/aggregate proofs in chunks feat:aggregate proofs in chunks Apr 25, 2025
@MarcosNicolau MarcosNicolau changed the title feat:aggregate proofs in chunks feat: aggregate proofs in chunks Apr 25, 2025
@MarcosNicolau MarcosNicolau changed the base branch from staging to refactor/agg-mode-redundancies April 25, 2025 18:56
@MarcosNicolau MarcosNicolau marked this pull request as ready for review April 25, 2025 22:04
Base automatically changed from refactor/agg-mode-redundancies to staging April 28, 2025 19:57
MauroToscano
MauroToscano requested changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@MauroToscano MauroToscano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to double check the soundness of this

@MauroToscano
Copy link
Contributor

This is unsound, you need to check if the aggregated proof came from the right ELF, you can test hacking it with another program that has the right public inputs but it's not fro man Agg proof. Also, don't do something that commits and with an if you don't commit in one case, make it more explicit

@JuArce JuArce changed the title feat: aggregate proofs in chunks feat(aggregation_mode): aggregate proofs in chunks May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauroToscano MauroToscano MauroToscano requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@MarcosNicolau MarcosNicolau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcosNicolau @MauroToscano