Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure minimal Node.js version #256

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ensure minimal Node.js version #256

wants to merge 3 commits into from

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Mar 23, 2023 •
edited
Loading

Main changes

  • Added Nodejs 16 as the minimum version and regenerated pkg lock file (422579b)
  • Added support for NVM

Changelog

@UlisesGascon
chore: added Nodejs 14 as the minimum version
2759aa3 
- Updated Engine version to 14 in pkg
- Regenerated package-lock
@UlisesGascon
chore: added nvm support
24f2ba2
@UlisesGascon UlisesGascon added this to the 6.0.0 milestone Mar 23, 2023
@UlisesGascon UlisesGascon marked this pull request as ready for review March 23, 2023 18:57
ruyadorno
ruyadorno requested changes Jun 1, 2023
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
.nvmrc Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@UlisesGascon UlisesGascon requested a review from ruyadorno June 12, 2023 12:01
ruyadorno
ruyadorno reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the package-lock.json file still removes all the v2 metadata, can you please remove these changes? ideally there's no change to that file (maybe only to update the small section that replicates the package.json engines data if that's the case)

@enterstudio enterstudio mentioned this pull request Jun 21, 2023
Open
@ngogiaphat
Copy link

v2 metadata what else ?

@enterstudio enterstudio mentioned this pull request Sep 26, 2023
Open
@enterstudio enterstudio mentioned this pull request Dec 15, 2023
Open
@enterstudio enterstudio mentioned this pull request Jan 6, 2024
Open
@enterstudio enterstudio mentioned this pull request Apr 16, 2024
Open
@enterstudio enterstudio mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno requested changes

@mischah mischah Awaiting requested review from mischah

@mshima mshima Awaiting requested review from mshima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@UlisesGascon @ngogiaphat @ruyadorno