Open
Conversation
yellowragz
commented
Dec 17, 2020
| ) | ||
|
|
||
| const ( | ||
| // Collection queries |
Owner
Author
There was a problem hiding this comment.
bisa dipisah file queries.go indent querynya dibenerin, syntax sqlnya di uppercase aja
yellowragz
commented
Dec 17, 2020
| "github.com/tokopedia/tokopoints/tracer" | ||
| ) | ||
|
|
||
| func GetNilaiSiswa(ctx context.Context, nim int64, sekolah, kelas string, mapel_id int64) (resp GetNilaiSiswaResponse, err error) { |
Owner
Author
There was a problem hiding this comment.
paramnya bisa jd satu struct terpisah GetNilaiSiswaParam
yellowragz
commented
Dec 17, 2020
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) |
Owner
Author
There was a problem hiding this comment.
GetDetailSekolah dan mappingGetNilaiSiswa bisa taruh setelah if else biar ga redundant
yellowragz
commented
Dec 17, 2020
| pb "github.com/tokopedia/grpc/code-review-workshop/proto" | ||
| ) | ||
|
|
||
| func (s *server) GetNilaiSiswa(ctx context.Context, req *pb.GetNilaiSiswaRequest) (resp *pb.GetNilaiSiswaResponse, err error) { |
Owner
Author
There was a problem hiding this comment.
param ctx klo ga dipake bisa dihilangkan
yellowragz
commented
Dec 17, 2020
| "github.com/tokopedia/code-review-workshop/tracer" | ||
| ) | ||
|
|
||
| type NilaiSiswa struct { |
Owner
Author
There was a problem hiding this comment.
struct nya bisa dipisah file types.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.