Resolving Errors with Non-Zero Returns #231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ise a non zero return code
for more information, see https://pre-commit.ci
Contributor
Author
|
@yehoshuadimarsky This is something that I am needing to continue to use this package moving forward, is there anything I can do to help get this implemented? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check to output from bcp command to ensure there was not a driver error even when the return code is zero. This happens on string truncation. It would just skip rows, and it the number was small enough, it was not even returning a non zero exit code. Making the program complete with no exception
Also, added some extendibility for the delimiter and quote chars. This will allow for adding those chars to the constants and having them validated as well. This will allow for more consistent behavior with those args from what the constants do.