open parameter "errors" should be error handler, not encoding (Issue #226) #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue open parameter "errors" should be error handler, not encoding #226
Hi,
I stumbled upon a bug in stdout decoding when running your lib against an SQL Server configured to German and returning "öß".
At following point of code, an error handling method needs to be specified, not an encoding:
bcpandas/bcpandas/utils.py
Line 272 in 8889280
proc = Popen( cmd, stdout=PIPE, stderr=STDOUT, encoding="utf-8", - errors="utf-8", + errors="replace", shell=with_shell, )see https://docs.python.org/3/library/io.html#io.TextIOWrapper for reference