enhance TkHtml test coverage and readability #1487
Merged
+85
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshabakhov
changed the title
sopronyr
reviewed
Oct 31, 2025
Contributor
Author
|
@sopronyr did I answer your question? check pls PR |
Contributor
Author
|
@yegor256 please, check the PR |
yegor256
reviewed
Dec 8, 2025
| () -> { | ||
| MatcherAssert.assertThat( | ||
| "Must reject null byte array body", | ||
| new RsPrint(new TkHtml(body.getBytes()).act(new RqFake())), |
Owner
There was a problem hiding this comment.
@eshabakhov what this indentation is for? Also, in all other tests. Looks wrong to me. I wonder how Qulice didn't catch this.
Contributor
Author
|
@yegor256 fixed, check please |
yegor256
reviewed
Dec 10, 2025
| * Test case for {@link TkHtml with empty body}. | ||
| * @since 0.10 | ||
| */ | ||
| final class TkHtmlEmptyTest { |
Owner
There was a problem hiding this comment.
@eshabakhov read this please: https://www.yegor256.com/2023/01/19/layout-of-tests.html
Contributor
Author
|
@yegor256 thanks for the article! Fixed, check please. Is it correct to check for null in tests like this? |
yegor256
reviewed
Dec 12, 2025
|
|
||
| @Test | ||
| void endsTextResponseBodyWithHtmlTag() throws Exception { | ||
| final String body = "<html><body>Hello comrade!/body></html>"; |
Owner
There was a problem hiding this comment.
Contributor
Author
|
@yegor256 hmm, okay. Fixed, please check |
Owner
|
@rultor merge |
Collaborator
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request solves #1435