fix: normalise email to lowercase in whitelist service#114
Open
AA-AdonayTecle wants to merge 2 commits into
Open
fix: normalise email to lowercase in whitelist service#114AA-AdonayTecle wants to merge 2 commits into
AA-AdonayTecle wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Emails from OAuth providers (Azure AD, Google, Cognito, OIDC) may
contain uppercase letters depending on the provider or user profile
configuration. The whitelist lookup and registration used an exact
string match, causing valid whitelisted users to be rejected when
the case of their email differed from the stored entry.
For example, a user logging in with "John.Smith@Company.com" would
fail the whitelist check if the stored entry was "john.smith@company.com".
Fix
Call
email.toLowerCase()in both "registerUser" and"checkWhitelistForEmail" in "server/services/whitelist.js". This
ensures all storage and comparisons are case-insensitive regardless
of what the OAuth provider returns.
The fix is in the service layer rather than individual controllers
so it applies consistently across all providers (Azure AD, Google,
Cognito, OIDC).