Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero Component Refactored #97

Closed
wants to merge 5 commits into from

Conversation

parthratra11
Copy link
Contributor

Pull Request Template

Summary

Hero Component Refactored

Fixes # (issue)

Type of Change

Please mark [X] for applicable items:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots/Videos (optional)

image

Copy link

vercel bot commented Jan 16, 2025

@parthratra11 is attempting to deploy a commit to the Yash Kumar Saini's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leetcode-journal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 1:20pm

@yashksaini-coder
Copy link
Owner

@parthratra11 The current Hero component is good but the theme toggler does not change the color of the main background body. Kindly fix it.

Hero.component.theme.webm

@yashksaini-coder yashksaini-coder added bug Something isn't working SWOC officially part of SWOC season 5 Under Review The Pull Request is under Review Frontend Related to the Frontend part Low Priority Low Priority issue labels Jan 16, 2025
@parthratra11
Copy link
Contributor Author

@yashksaini-coder fixed it, raising a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend Related to the Frontend part Low Priority Low Priority issue SWOC officially part of SWOC season 5 Under Review The Pull Request is under Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants