-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAQs + learn-more made responsive #81
Conversation
parthratra11
commented
Jan 13, 2025
Footer made dynamic
Copyright centered + Footer padding fixed
Theme toggle button fixed
@parthratra11 is attempting to deploy a commit to the Yash Kumar Saini's projects Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fixes #75 @parthratra11 Please follow standard PR template when raising PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parthratra11 I have seen many times in your PRs that there are a lot of edit on simple (') & ("). Please refrain from doing that, whatever formatter or linter you have kindly disable it.
] | ||
{ | ||
question: "What is Leetcode Journal, and how can it help me?", | ||
answer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there so much space here @parthratra11 Fix this
components/ui/shiny-button.tsx
Outdated
@@ -44,7 +44,7 @@ const ShinyButton = React.forwardRef<HTMLButtonElement, ShinyButtonProps>( | |||
{...props} | |||
className={cn( | |||
"relative rounded-lg px-6 py-2 font-medium backdrop-blur-xl transition-shadow duration-300 ease-in-out hover:shadow dark:bg-[radial-gradient(circle_at_50%_0%,hsl(var(--primary)/10%)_0%,transparent_60%)] dark:hover:shadow-[0_0_20px_hsl(var(--primary)/10%)]", | |||
className, | |||
className |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned before, don't add or edit these components.
Okay |
@yashksaini-coder don't pick out any spaces, or missing commas, if the code is working fine without them then let it be. Also the linter makes the code better by removing unncessary indentations, commas or spaces, it doesn't affect the functionality. |
@yashksaini-coder i have raised a new PR, kindly check. |