Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQs + learn-more made responsive #81

Closed
wants to merge 22 commits into from

Conversation

parthratra11
Copy link
Contributor

image
image

Copy link

vercel bot commented Jan 13, 2025

@parthratra11 is attempting to deploy a commit to the Yash Kumar Saini's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leetcode-journal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 2:28pm

@yashksaini-coder
Copy link
Owner

Fixes #75 @parthratra11 Please follow standard PR template when raising PR.

@yashksaini-coder yashksaini-coder added enhancement New feature or request SWOC officially part of SWOC season 5 Intermediate SWOC Level 2 issue Frontend Related to the Frontend part labels Jan 13, 2025
Copy link
Owner

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthratra11 I have seen many times in your PRs that there are a lot of edit on simple (') & ("). Please refrain from doing that, whatever formatter or linter you have kindly disable it.

]
{
question: "What is Leetcode Journal, and how can it help me?",
answer:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there so much space here @parthratra11 Fix this

@@ -44,7 +44,7 @@ const ShinyButton = React.forwardRef<HTMLButtonElement, ShinyButtonProps>(
{...props}
className={cn(
"relative rounded-lg px-6 py-2 font-medium backdrop-blur-xl transition-shadow duration-300 ease-in-out hover:shadow dark:bg-[radial-gradient(circle_at_50%_0%,hsl(var(--primary)/10%)_0%,transparent_60%)] dark:hover:shadow-[0_0_20px_hsl(var(--primary)/10%)]",
className,
className
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned before, don't add or edit these components.

@yashksaini-coder yashksaini-coder added the Under Review The Pull Request is under Review label Jan 13, 2025
@yashksaini-coder yashksaini-coder added the Changes requested Changes are requested label Jan 13, 2025
@parthratra11
Copy link
Contributor Author

Okay

@parthratra11
Copy link
Contributor Author

@yashksaini-coder don't pick out any spaces, or missing commas, if the code is working fine without them then let it be. Also the linter makes the code better by removing unncessary indentations, commas or spaces, it doesn't affect the functionality.

@parthratra11
Copy link
Contributor Author

@yashksaini-coder i have raised a new PR, kindly check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Changes are requested enhancement New feature or request Frontend Related to the Frontend part Intermediate SWOC Level 2 issue SWOC officially part of SWOC season 5 Under Review The Pull Request is under Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants