Navbar made responsive #74
Conversation
parthratra11
commented
Jan 11, 2025
parthratra11
commented
Footer made dynamic
Copyright centered + Footer padding fixed
Theme toggle button fixed
|
@parthratra11 is attempting to deploy a commit to the Yash Kumar Saini's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
README.md
Outdated
There was a problem hiding this comment.
Remove changes to the README entirely. Don't include it
| }`} | ||
| > | ||
| {item.label} | ||
| </Link> | ||
| ))} | ||
| </div> | ||
| <div className="hidden lg:flex items-center space-x-4"> | ||
| <Link href="/auth/signin" className="text-sm font-medium text-muted-foreground hover:text-primary"> | ||
| <Link |
There was a problem hiding this comment.
Why shifted to new line, ??
| {navItems.map((item) => ( | ||
| <Link | ||
| key={item.href} | ||
| href={item.href} | ||
| className={`text-sm font-medium transition-colors hover:text-primary ${ | ||
| pathname === item.href ? "text-primary" : "text-muted-foreground" | ||
| pathname === item.href |
There was a problem hiding this comment.
Shifting to new lines is unnecessary
components/ui/shiny-button.tsx
Outdated
There was a problem hiding this comment.
This is a Ui library component. There is no need to make changes to this file. Remove it
There was a problem hiding this comment.
this is because of the prettier extension i use in vscode, it turns the code into a more readable format.
if it isn't affecting the functionality of the app and is making code more readable then you may accept the PR, else lmk, i'll change it and raise a new PR
There was a problem hiding this comment.
@yashksaini-coder also there is no change in ui/shiny-button.tsx, there is just on empty line after line 73, because i might have pressed 'enter' there. Kindly confirm.
yashksaini-coder
added
good first issue
|
@parthratra11 Kindly complete the requested changes first |
