-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Theme Toggle Button Functionality #36
Improved Theme Toggle Button Functionality #36
Conversation
@pujaak is attempting to deploy a commit to the Yash Kumar Saini's projects Team on Vercel. A member of the Team first needs to authorize it. |
Welcome, new contributor!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pujaak Thank you for your contributions
@yashksaini-coder Hey, I think I need to make more changes to the code I have submitted, as I can see that both the moon and sun icons appear and overlap with each other when the website is visited for the first time or refreshed. |
Okay Im raising another issue for that @pujaak |
@yashksaini-coder I have added the check, so the icons do not overlap at the start, though they appear after the theme is rendered, I guess one or half second later. |
Description:
This pull request addresses the issue with the theme toggle button on the website. The previous behavior involved a dropdown that required an additional action to change the theme. I have improved the functionality so that the toggle button directly switches between light and dark themes without the need for a dropdown.
Fixes #34
Changes Made:
Screenshots
Testing Done: