Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 Add Navbar component and integrate the theme toggle button #16

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

kekubhai
Copy link
Contributor

@kekubhai kekubhai commented Jan 5, 2025

Resolved the Issue #3 , This give the edge to the user to get to know what pages and directories are availabe in the website and check that eventually. Hope it gets merged soon

Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leetcode-journal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2025 9:02am

Copy link

github-actions bot commented Jan 5, 2025

Welcome, new contributor!

   Please make sure you've read our [Contributing Guide](README.md) and we look forward to reviewing your Pull request shortly ✨

Copy link
Owner

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete the requested changes

<span className="text-xl font-semibold">LeetCodeJournal</span>
</div>
<div className="hidden lg:flex space-x-6">
<Link href="#" className="hover:text-purple-400 hover:animate-spin">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kekubhai Remove animations from the items, they are not necessary.
image

@yashksaini-coder yashksaini-coder added SWOC officially part of SWOC season 5 Beginner SWOC Level 1 issue labels Jan 5, 2025
Copy link

github-actions bot commented Jan 5, 2025

Welcome, new contributor!

   Please make sure you've read our [Contributing Guide](README.md) and we look forward to reviewing your Pull request shortly ✨

@kekubhai
Copy link
Contributor Author

kekubhai commented Jan 5, 2025

Removed the Animation changes and made it simple as possible as you wanted

@yashksaini-coder yashksaini-coder merged commit ea8ba50 into yashksaini-coder:main Jan 5, 2025
3 checks passed
@yashksaini-coder yashksaini-coder added the Points Assigned The points have been assigned on OS Lead label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner SWOC Level 1 issue Points Assigned The points have been assigned on OS Lead SWOC officially part of SWOC season 5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants