Skip to content

Conversation

@justingshreve
Copy link

Added ability to trigger hovercard via click, instead of just mouseenter...

<hovercard hover-tmpl-url="/app/templates/test.html" trigger="click"></hovercard>

Still defaults to mouseenter, unless attr.trigger = click exists.

Had to change some stuff in your tests too, to get them to pass. Couldn't get them to pass even when I pulled down fresh.

There are a lot of commits, but changes are minor. Played around with some stuff in various commits.

@yaru22
Copy link
Owner

yaru22 commented Oct 23, 2015

Hi @justingshreve, thanks for your contribution. Before I merge it in, could you add an example to the demo for click-to-show?
Also, from the code, it looks like when you click to show the hover card, it will disappear when your mouse leaves the card. Wouldn't it be better to dismiss the hover card (if it was brought up by a click) when you click elsewhere instead of moving the mouse cursor out? What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants