Implements npm web login support #6981
Merged
+156
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Npm plans to fully remove the
/-/user/org.couchdb.user:<name>endpoint. Since we use this endpoint to login, we need to implement support for the newer/-/v1/loginendpoint.How did you fix it?
A new option,
--web-login, enables the web login flow (and fallbacks to the password flow if the web flow isn't supported). This flag is automatically enabled for the npm registry. This is technically a breaking change, but since it's the registry that plans to make that change I think it's ok.Checklist