Skip to content

test(acceptance-tests): add tests for provenance #6755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 9, 2025

Conversation

GauBen
Copy link
Contributor

@GauBen GauBen commented Apr 7, 2025

What's the problem this PR addresses?

Follow-up #6750: add tests

How did you fix it?

New npm publish acceptance tests that verifies the provenance statement validity

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@GauBen GauBen force-pushed the test/provenance branch from 916d297 to 8524f7a Compare April 7, 2025 23:14
@GauBen GauBen force-pushed the test/provenance branch from 8524f7a to 22cd5f6 Compare April 7, 2025 23:25
@GauBen
Copy link
Contributor Author

GauBen commented Apr 7, 2025

For security reasons, forks cannot mint id tokens

@GauBen
Copy link
Contributor Author

GauBen commented Apr 7, 2025

I enabled actions on my fork of Yarn to check if it passes, and it does!

https://github.com/GauBen/berry/actions/runs/14321711531/job/40139791053?pr=1#step:5:36

@GauBen GauBen marked this pull request as ready for review April 7, 2025 23:50
@GauBen GauBen requested a review from arcanis as a code owner April 7, 2025 23:50
@arcanis arcanis enabled auto-merge April 9, 2025 13:06
arcanis
arcanis previously approved these changes Apr 9, 2025
@arcanis arcanis added this pull request to the merge queue Apr 9, 2025
@arcanis arcanis removed this pull request from the merge queue due to a manual request Apr 9, 2025
@arcanis arcanis merged commit e31ffe8 into yarnpkg:master Apr 9, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants