Improve pnp loader speed and memory: jszip implementation

.yarn/versions/01575767.yml

@@ -0,0 +1,31 @@
+releases:
+  "@yarnpkg/cli": minor
+  "@yarnpkg/libzip": minor
+  "@yarnpkg/plugin-pnp": minor
+  "@yarnpkg/pnp": minor
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-file"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - vscode-zipfs
+  - "@yarnpkg/builder"
+  - "@yarnpkg/core"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/fslib"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/pnpify"
+  - "@yarnpkg/sdks"

.yarnrc.yml

@@ -15,6 +15,8 @@ immutablePatterns:
 
 initScope: yarnpkg
 
+pnpZipBackend: js
+
 npmPublishAccess: public
 
 packageExtensions:

packages/acceptance-tests/pkg-tests-specs/sources/basic.test.js

@@ -5,6 +5,9 @@ const {
 
 const configs = [{
   nodeLinker: `pnp`,
+}, {
+  nodeLinker: `pnp`,
+  pnpZipBackend: `js`,
 }, {
   nodeLinker: `pnpm`,
 }, {
@@ -13,7 +16,7 @@ const configs = [{
 
 describe(`Basic tests`, () => {
   for (const config of configs) {
-    describe(`w/ the ${config.nodeLinker} linker`, () => {
+    describe(`w/ the ${config.nodeLinker} linker${config.pnpZipBackend ? ` and ${config.pnpZipBackend} zip backend` : ``}`, () => {
       test(
         `it should correctly handle browser fields in package.json`,
         makeTemporaryEnv(

packages/plugin-pnp/sources/PnpLinker.ts

@@ -267,6 +267,7 @@ export class PnpInstaller implements Installer {
     const ignorePattern = miscUtils.buildIgnorePattern([`.yarn/sdks/**`, ...this.opts.project.configuration.get(`pnpIgnorePatterns`)]);
     const packageRegistry = this.packageRegistry;
     const shebang = this.opts.project.configuration.get(`pnpShebang`);
+    const pnpZipBackend = this.opts.project.configuration.get(`pnpZipBackend`);
 
     if (pnpFallbackMode === `dependencies-only`)
       for (const pkg of this.opts.project.storedPackages.values())
@@ -281,6 +282,7 @@ export class PnpInstaller implements Installer {
       fallbackExclusionList,
       fallbackPool,
       ignorePattern,
+      pnpZipBackend,
       packageRegistry,
       shebang,
     });

packages/plugin-pnp/sources/index.ts

@@ -1,6 +1,7 @@
 import {Hooks as CoreHooks, Plugin, Project, SettingsType, WindowsLinkType} from '@yarnpkg/core';
 import {Filename, PortablePath, npath, ppath, xfs}                          from '@yarnpkg/fslib';
 import {Hooks as StageHooks}                                                from '@yarnpkg/plugin-stage';
+import {PnpZipBackend}                                                      from '@yarnpkg/pnp';
 import {pathToFileURL}                                                      from 'url';
 
 import {PnpLinker}                                                          from './PnpLinker';
@@ -70,12 +71,14 @@ declare module '@yarnpkg/core' {
     nodeLinker: string;
     winLinkType: string;
     pnpMode: string;
+    minizip: boolean;
     pnpShebang: string;
     pnpIgnorePatterns: Array<string>;
     pnpEnableEsmLoader: boolean;
     pnpEnableInlining: boolean;
     pnpFallbackMode: string;
     pnpUnpluggedFolder: PortablePath;
+    pnpZipBackend: PnpZipBackend;
   }
 }
 
@@ -90,6 +93,11 @@ const plugin: Plugin<CoreHooks & StageHooks> = {
       type: SettingsType.STRING,
       default: `pnp`,
     },
+    minizip: {
+      description: `Whether Yarn should use minizip to extract archives`,
+      type: SettingsType.BOOLEAN,
+      default: false,
+    },
     winLinkType: {
       description: `Whether Yarn should use Windows Junctions or symlinks when creating links on Windows.`,
       type: SettingsType.STRING,
@@ -115,6 +123,15 @@ const plugin: Plugin<CoreHooks & StageHooks> = {
       default: [],
       isArray: true,
     },
+    pnpZipBackend: {
+      description: `Whether to use the experimental js implementation for the ZipFS`,
+      type: SettingsType.STRING,
+      values: [
+        `libzip`,
+        `js`,
+      ],
+      default: `libzip`,
+    },
     pnpEnableEsmLoader: {
       description: `If true, Yarn will generate an ESM loader (\`.pnp.loader.mjs\`). If this is not explicitly set Yarn tries to automatically detect whether ESM support is required.`,
       type: SettingsType.BOOLEAN,

packages/yarnpkg-libzip/package.json

@@ -38,6 +38,7 @@
   },
   "devDependencies": {
     "@types/prettier": "1.19.0",
+    "globby": "^11.0.1",
     "prettier": "^1.19.1"
   },
   "dependencies": {